![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
Entry tags:
egoboo
Woohoo! I just came from a code review where I made enough of a contribution that Sean the QA guy (who runs them) said he's now putting me on the list for *all* of them. (Code reviews are weekly and constrained to be no longer than an hour, so that amounts to a commitment of a couple of hours a week, which seems reasonable to me. I told him that if it was ok with Werner, our manager, it's ok with me.)
The rule had been that the following people attend: the developer whose code is being reviewed (duh), Sean (our only QA person), a random developer, and a random "defender of the faith" (enforcer of coding standards and so on; currently the set is Paul and Werner, but Paul said he wants to groom me for this). When these were set up, I was under the impression that I was part of the "random developer" pool, and I figured I just hadn't been called for one yet. (We've only been doing this for a couple months, and we have about 15 developers.) But apparently that wasn't the case; Sean didn't have me on his list at all, except as a potential review target. The only reason I was at this one is that I asked to be.
(I was involved in the code.)
(There is a tool for randomly selecting older code to review; it crawls the code base and assigns points based on length, comment density, and various measures of code complexity. Since I've written some test code, I could end up as a reviewee, though I'm pretty good about comments and my code isn't very complex.)
The other thing that was cool about this one is that we have a new engineer who was there as an observer, and I was answering most of the questions he was asking. And then another engineer spotted a potential problem (which I immediately recognized as an actual problem)
but the author of the code didn't see what he was saying, but I did, so I acted as "translator". I think I scored some points for that.
The rule had been that the following people attend: the developer whose code is being reviewed (duh), Sean (our only QA person), a random developer, and a random "defender of the faith" (enforcer of coding standards and so on; currently the set is Paul and Werner, but Paul said he wants to groom me for this). When these were set up, I was under the impression that I was part of the "random developer" pool, and I figured I just hadn't been called for one yet. (We've only been doing this for a couple months, and we have about 15 developers.) But apparently that wasn't the case; Sean didn't have me on his list at all, except as a potential review target. The only reason I was at this one is that I asked to be.
(I was involved in the code.)
(There is a tool for randomly selecting older code to review; it crawls the code base and assigns points based on length, comment density, and various measures of code complexity. Since I've written some test code, I could end up as a reviewee, though I'm pretty good about comments and my code isn't very complex.)
The other thing that was cool about this one is that we have a new engineer who was there as an observer, and I was answering most of the questions he was asking. And then another engineer spotted a potential problem (which I immediately recognized as an actual problem)
but the author of the code didn't see what he was saying, but I did, so I acted as "translator". I think I scored some points for that.